
Added [rhysd/actionlint](https://github.com/rhysd/actionlint/) a static checker for GitHub Actions workflow files. Install locally with `brew install actionlint` the run with `actionlint`. Inspired by: https://github.com/zed-industries/zed/pull/34704 which yielded this observation: > In github actions: > 1. strings are truthy > 2. `${{ }}` will become a string if it doesn't wrap the whole value. > > So `if: false && true` becomes `false` > and `if: ${{ false && true }}` becomes `false` > but `if: false && ${{ true }}` becomes `"false && true"` which evaluates true > The reason you sometimes need `${{ }}` is because YAML doesn't like `!` > so `if: !false` is invalid yaml > and `if: ${{ !false }}` works just fine. Changes: - Add `actionlint` job - Refactor `job_spec` job to be more readable - Fix all `actionlint` and `shellcheck` errors in Actions workflows (62 in all) - Add `self-mini-macos` and `self-32vcpu-windows-2022` labels to self-hosted runners. Not strictly related, but useful if you need to take a runner out of the rotation (since `macOS`, `self-hosted`, and `ARM64` are auto-set and cannot be added/removed). - Change ci.yml macos_relase to target `self-mini-macos` instead of `bundle` which was previously deprecated. This would've caught the error fixed in https://github.com/zed-industries/zed/pull/34704. Here's what that [job failure](https://github.com/zed-industries/zed/actions/runs/16376993944/job/46279281842?pr=34729) would've looked like. Release Notes: - N/A
30 lines
981 B
YAML
30 lines
981 B
YAML
# Configuration related to self-hosted runner.
|
|
self-hosted-runner:
|
|
# Labels of self-hosted runner in array of strings.
|
|
labels:
|
|
# GitHub-hosted Runners
|
|
- github-8vcpu-ubuntu-2404
|
|
- github-16vcpu-ubuntu-2404
|
|
- windows-2025-16
|
|
- windows-2025-32
|
|
- windows-2025-64
|
|
# Buildjet Ubuntu 20.04 - AMD x86_64
|
|
- buildjet-2vcpu-ubuntu-2004
|
|
- buildjet-4vcpu-ubuntu-2004
|
|
- buildjet-8vcpu-ubuntu-2004
|
|
- buildjet-16vcpu-ubuntu-2004
|
|
- buildjet-32vcpu-ubuntu-2004
|
|
# Buildjet Ubuntu 22.04 - AMD x86_64
|
|
- buildjet-2vcpu-ubuntu-2204
|
|
- buildjet-4vcpu-ubuntu-2204
|
|
- buildjet-8vcpu-ubuntu-2204
|
|
- buildjet-16vcpu-ubuntu-2204
|
|
- buildjet-32vcpu-ubuntu-2204
|
|
# Buildjet Ubuntu 22.04 - Graviton aarch64
|
|
- buildjet-8vcpu-ubuntu-2204-arm
|
|
- buildjet-16vcpu-ubuntu-2204-arm
|
|
- buildjet-32vcpu-ubuntu-2204-arm
|
|
- buildjet-64vcpu-ubuntu-2204-arm
|
|
# Self Hosted Runners
|
|
- self-mini-macos
|
|
- self-32vcpu-windows-2022
|