Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove another false-positive Danger message (#19769)

Browse source 
Follow-up of https://github.com/zed-industries/zed/pull/19151

Ignores any URLs aftrer `Release Notes:` (if present) and after
`Follow-up of` and `Part of` words.


Release Notes:

- N/A
This commit is contained in:
Kirill Bulatov 2024-10-26 01:55:46 +03:00 • committed by GitHub
parent 78ed0c9312
commit 1acebb3c47
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

24
script/danger/dangerfile.ts
View file

@ -8,7 +8,7 @@ prHygiene({
}, },
}); });
const RELEASE_NOTES_PATTERN = new RegExp("Release Notes:\\r?\\n\\s+-", "gm"); const RELEASE_NOTES_PATTERN = /Release Notes:\r?\n\s+-/gm;
const body = danger.github.pr.body; const body = danger.github.pr.body;
const hasReleaseNotes = RELEASE_NOTES_PATTERN.test(body); const hasReleaseNotes = RELEASE_NOTES_PATTERN.test(body);
@ -36,28 +36,22 @@ if (!hasReleaseNotes) {
); );
} }
const ISSUE_LINK_PATTERN = new RegExp( const ISSUE_LINK_PATTERN =
"(?<!(?:Close[sd]?|Fixe[sd]|Resolve[sd]|Implement[sed])\\s+)https://github\\.com/[\\w-]+/[\\w-]+/issues/\\d+", /(?<!(?:Close[sd]?|Fixe[sd]|Resolve[sd]|Implement[sed]|Follow-up of|Part of)\s+)https:\/\/github\.com\/[\w-]+\/[\w-]+\/issues\/\d+/gi;
"gi"
);
const bodyWithoutReleaseNotes = hasReleaseNotes ? body.split(/Release Notes:/)[0] : body;
const includesIssueUrl = ISSUE_LINK_PATTERN.test(body); const includesIssueUrl = ISSUE_LINK_PATTERN.test(bodyWithoutReleaseNotes);
if (includesIssueUrl) { if (includesIssueUrl) {
const matches = body.match(ISSUE_LINK_PATTERN) ?? []; const matches = bodyWithoutReleaseNotes.match(ISSUE_LINK_PATTERN) ?? [];
const issues = matches const issues = matches
.map((match) => .map((match) => match.replace(/^#/, "").replace(/https:\/\/github\.com\/zed-industries\/zed\/issues\//, ""))
match
.replace(/^#/, "")
.replace(/https:\/\/github\.com\/zed-industries\/zed\/issues\//, ""),
)
.filter((issue, index, self) => self.indexOf(issue) === index); .filter((issue, index, self) => self.indexOf(issue) === index);
const issuesToReport = issues.map((issue) => `#${issue}`).join(", ");
message( message(
[ [
"This PR includes links to the following GitHub Issues: " + `This PR includes links to the following GitHub Issues: ${issuesToReport}`,
issues.map((issue) => `#${issue}`).join(", "),
"If this PR aims to close an issue, please include a `Closes #ISSUE` line at the top of the PR body.", "If this PR aims to close an issue, please include a `Closes #ISSUE` line at the top of the PR body.",
].join("\n"), ].join("\n"),
); );