Increase cx.condition
timeout to fix flaky test (#28822)
We've been seeing `test_no_duplicated_completion_requests` fail randomly with the error "condition timed out". But it's always failing on MacOS, and MacOS sets a shorter timeout of 100ms, compared to 1s from other platforms, this PR increases MacOS's timeout to match other platforms'. Release Notes: - N/A
This commit is contained in:
parent
134a0563c2
commit
4e8ecfc0c4
1 changed files with 1 additions and 6 deletions
|
@ -589,11 +589,6 @@ impl<V> Entity<V> {
|
|||
use postage::prelude::{Sink as _, Stream as _};
|
||||
|
||||
let (tx, mut rx) = postage::mpsc::channel(1024);
|
||||
let timeout_duration = if cfg!(target_os = "macos") {
|
||||
Duration::from_millis(100)
|
||||
} else {
|
||||
Duration::from_secs(1)
|
||||
};
|
||||
|
||||
let mut cx = cx.app.borrow_mut();
|
||||
let subscriptions = (
|
||||
|
@ -615,7 +610,7 @@ impl<V> Entity<V> {
|
|||
let handle = self.downgrade();
|
||||
|
||||
async move {
|
||||
crate::util::timeout(timeout_duration, async move {
|
||||
crate::util::timeout(Duration::from_secs(1), async move {
|
||||
loop {
|
||||
{
|
||||
let cx = cx.borrow();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue