Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -119,7 +119,7 @@ impl zed::Extension for GlslExtension {
|
|||
) -> Result<Option<serde_json::Value>> {
|
||||
let settings = LspSettings::for_worktree("glsl_analyzer", worktree)
|
||||
.ok()
|
||||
.and_then(|lsp_settings| lsp_settings.settings.clone())
|
||||
.and_then(|lsp_settings| lsp_settings.settings)
|
||||
.unwrap_or_default();
|
||||
|
||||
Ok(Some(serde_json::json!({
|
||||
|
|
|
@ -94,7 +94,7 @@ impl zed::Extension for HtmlExtension {
|
|||
) -> Result<Option<zed::serde_json::Value>> {
|
||||
let settings = LspSettings::for_worktree(server_id.as_ref(), worktree)
|
||||
.ok()
|
||||
.and_then(|lsp_settings| lsp_settings.settings.clone())
|
||||
.and_then(|lsp_settings| lsp_settings.settings)
|
||||
.unwrap_or_default();
|
||||
Ok(Some(settings))
|
||||
}
|
||||
|
|
|
@ -151,7 +151,7 @@ impl zed::Extension for RuffExtension {
|
|||
) -> Result<Option<zed_extension_api::serde_json::Value>> {
|
||||
let settings = LspSettings::for_worktree(server_id.as_ref(), worktree)
|
||||
.ok()
|
||||
.and_then(|lsp_settings| lsp_settings.initialization_options.clone())
|
||||
.and_then(|lsp_settings| lsp_settings.initialization_options)
|
||||
.unwrap_or_default();
|
||||
Ok(Some(settings))
|
||||
}
|
||||
|
@ -163,7 +163,7 @@ impl zed::Extension for RuffExtension {
|
|||
) -> Result<Option<zed_extension_api::serde_json::Value>> {
|
||||
let settings = LspSettings::for_worktree(server_id.as_ref(), worktree)
|
||||
.ok()
|
||||
.and_then(|lsp_settings| lsp_settings.settings.clone())
|
||||
.and_then(|lsp_settings| lsp_settings.settings)
|
||||
.unwrap_or_default();
|
||||
Ok(Some(settings))
|
||||
}
|
||||
|
|
|
@ -113,7 +113,7 @@ impl zed::Extension for SnippetExtension {
|
|||
) -> Result<Option<zed_extension_api::serde_json::Value>> {
|
||||
let settings = LspSettings::for_worktree(server_id.as_ref(), worktree)
|
||||
.ok()
|
||||
.and_then(|lsp_settings| lsp_settings.settings.clone())
|
||||
.and_then(|lsp_settings| lsp_settings.settings)
|
||||
.unwrap_or_else(|| {
|
||||
json!({
|
||||
"max_completion_items": 20,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue