Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not set rules by default for eslint (#8545)

Browse source 
Follow-up to and fix for #8537.

Turns out that if you set `rules: []` it doesn't mean "no matchers", but
it means "no rules". So let's not set a default here.

Release Notes:

- N/A, see #8537

Co-authored-by: Conrad <conrad@zed.dev>
This commit is contained in:
Thorsten Ball 2024-02-28 18:39:54 +01:00 • committed by GitHub
parent d0ffd51bb1
commit 7efa8d079d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/languages/src/typescript.rs
View file

@ -241,7 +241,6 @@ impl LspAdapter for EsLintLspAdapter {
// We enable this, but without also configuring `code_actions_on_format` // We enable this, but without also configuring `code_actions_on_format`
// in the Zed configuration, it doesn't have an effect. // in the Zed configuration, it doesn't have an effect.
"enable": true, "enable": true,
"rules": []
}); });
if let Some(code_action_settings) = eslint_user_settings if let Some(code_action_settings) = eslint_user_settings