Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix modality indicators in user menu (#13228)

Browse source 
This PR updates the modality indicators in the user menu after #12940.

We use the ellipsis throughout the app to indicate that a menu action
will open a modal (e.g., the theme selector), so "Themes" needs the
trailing ellipsis.

Whereas the "Extensions" entry opens up a new tab, which we don't
indicate that same way.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-06-18 15:50:18 -04:00 • committed by GitHub
parent 6cea9813ad
commit c84d432b5f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/collab_ui/src/collab_titlebar_item.rs
View file

@ -911,8 +911,8 @@ impl CollabTitlebarItem {
ContextMenu::build(cx, |menu, _| { ContextMenu::build(cx, |menu, _| {
menu.action("Settings", zed_actions::OpenSettings.boxed_clone()) menu.action("Settings", zed_actions::OpenSettings.boxed_clone())
.action("Key Bindings", Box::new(zed_actions::OpenKeymap)) .action("Key Bindings", Box::new(zed_actions::OpenKeymap))
.action("Themes", theme_selector::Toggle::default().boxed_clone()) .action("Themes…", theme_selector::Toggle::default().boxed_clone())
.action("Extensions...", extensions_ui::Extensions.boxed_clone()) .action("Extensions", extensions_ui::Extensions.boxed_clone())
.separator() .separator()
.action("Sign Out", client::SignOut.boxed_clone()) .action("Sign Out", client::SignOut.boxed_clone())
}) })
@ -940,8 +940,8 @@ impl CollabTitlebarItem {
ContextMenu::build(cx, |menu, _| { ContextMenu::build(cx, |menu, _| {
menu.action("Settings", zed_actions::OpenSettings.boxed_clone()) menu.action("Settings", zed_actions::OpenSettings.boxed_clone())
.action("Key Bindings", Box::new(zed_actions::OpenKeymap)) .action("Key Bindings", Box::new(zed_actions::OpenKeymap))
.action("Themes", theme_selector::Toggle::default().boxed_clone()) .action("Themes…", theme_selector::Toggle::default().boxed_clone())
.action("Extensions...", extensions_ui::Extensions.boxed_clone()) .action("Extensions", extensions_ui::Extensions.boxed_clone())
}) })
.into() .into()
}) })