collab: Lookup avatars by GitHub ID instead of username (#33523)
Closes: https://github.com/zed-industries/zed/issues/19207 This will correctly show Avatars for recently renamed/deleted users and for enterprise users where the username avatar url triggers a redirect to an auth prompt. Also saves a request (302 redirect) per avatar. Tested locally and avatars loaded as expected. Release Notes: - N/A
This commit is contained in:
parent
865dd4c5fc
commit
e3ce0618a3
1 changed files with 2 additions and 2 deletions
|
@ -734,8 +734,8 @@ impl Database {
|
||||||
users.push(proto::User {
|
users.push(proto::User {
|
||||||
id: user.id.to_proto(),
|
id: user.id.to_proto(),
|
||||||
avatar_url: format!(
|
avatar_url: format!(
|
||||||
"https://github.com/{}.png?size=128",
|
"https://avatars.githubusercontent.com/u/{}?s=128&v=4",
|
||||||
user.github_login
|
user.github_user_id
|
||||||
),
|
),
|
||||||
github_login: user.github_login,
|
github_login: user.github_login,
|
||||||
name: user.name,
|
name: user.name,
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue