Antonio Scandurra
2923b71f83
Replace WindowContext::notify
with WindowContext::refresh
2024-01-10 17:27:02 +01:00
Marshall Bowers
aff119b80a
Fix possessive "its" in docs and comments ( #3998 )
...
This PR fixes a number of places where we were incorrectly using "it's"
where we needed to use the possessive "its".
Release Notes:
- N/A
2024-01-10 10:09:48 -05:00
Antonio Scandurra
d0c101cb6e
Reuse depth map entries and retain element states for cached trees
2024-01-10 15:00:40 +01:00
Kirill Bulatov
c197ea49ca
Simplify uniform list scrolling logic
2024-01-10 13:45:50 +02:00
Kirill Bulatov
f57ff1c660
Make the scroll position updated as soon as possible to the correct deferred value
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2024-01-10 12:16:06 +02:00
Antonio Scandurra
881c532256
Insert primitives associated with views from a previous scene
2024-01-10 10:50:16 +01:00
Kirill Bulatov
927e0db750
An attempt to defer scrolls during empty initial state
2024-01-10 11:26:23 +02:00
Kirill Bulatov
6809b92e34
Disable synthetic drag on drag and drop
...
Otherwise, conflicting MouseMove events are generated and page regions start to flicker.
2024-01-10 11:18:45 +02:00
Conrad Irwin
5d3f5611e5
guest promotion ( #3969 )
...
Release Notes:
- Adds the ability to promote read-only guests to read-write
participants in calls
2024-01-09 22:21:13 -07:00
Conrad Irwin
2ca462722c
Fix some tests (mostly more run_until_parked's...)
2024-01-09 22:14:11 -07:00
Conrad Irwin
72c022f413
Ensure focus-sensitive tests have active windows
2024-01-09 21:38:06 -07:00
Conrad Irwin
1bf33b4b61
Ensure focus_in and focus_out fire on window activation
...
Also:
- Rename cx.on_blur to cx.on_focus_lost
- Fix a bug where notify calls in focus handlers were ignored
- Fix a bug where vim would get stuck in the wrong mode when switching
windows
2024-01-09 20:55:00 -07:00
Mikayla Maki
45baad2825
Remove or fix stale todos ( #3990 )
...
The software equivalent of dusting
Release Notes:
-
2024-01-09 18:37:35 -08:00
Mikayla
e786e22121
And a few more todos
2024-01-09 16:41:17 -08:00
Mikayla
9ce7ef8949
Remove the last of the major todos
2024-01-09 16:14:54 -08:00
Conrad Irwin
276bfa0fab
Merge branch 'main' into guest-promotion
2024-01-09 16:28:42 -07:00
Mikayla
ed263a7b5c
Resolve more todos
2024-01-09 15:08:05 -08:00
Mikayla
80790d921d
Fix / remove small todos
2024-01-09 14:16:46 -08:00
Mikayla Maki
447bfca942
Add a test to catch keybinding bounds issue ( #3966 )
...
Add a test to catch regressions to
https://github.com/zed-industries/zed/pull/3964
Thanks for the idea @ConradIrwin
TODO:
- [ ] Fix immediate stack overflow in test
Release Notes:
- N/A
2024-01-09 12:03:48 -08:00
Mikayla
1728c4eacc
Fixed test
2024-01-09 11:52:03 -08:00
Julia
5b1894a9b1
Take into account multiple scroll deltas within a single frame ( #3982 )
...
Release Notes:
- Fixed an issue where all but the last scroll event would be dropped if
there were multiple within a single frame.
2024-01-09 14:51:26 -05:00
Marshall Bowers
74dadd68d2
Clean up references in doc comments ( #3983 )
...
This PR cleans up a number of references in doc comments so that
`rustdoc` will link and display them correctly.
Release Notes:
- N/A
2024-01-09 14:48:48 -05:00
Julia
463270ed36
Take into account multiple scroll deltas within a single frame
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2024-01-09 14:32:43 -05:00
Nathan Sobo
42cbd103fb
Even more docs
...
Co-authored-by: Conrad <conrad@zed.dev>
2024-01-09 12:02:12 -07:00
Nathan Sobo
458c672a72
Add more API docs
...
Co-Authored-By: Conrad <conrad@zed.dev>
2024-01-09 11:16:56 -07:00
Nathan Sobo
59f41acb82
Add a bunch of docs
...
Co-Authored-By: Conrad <conrad@zed.dev>
Co-Authored-By: Mikayla <mikayla@zed.dev>
2024-01-09 11:02:57 -07:00
Antonio Scandurra
0c6d107740
Introduce on_request_frame
2024-01-09 18:21:10 +01:00
Antonio Scandurra
3bb29acd26
💄
2024-01-09 17:34:57 +01:00
Marshall Bowers
f0ef63bfa0
gpui: Add SharedUrl
type ( #3975 )
...
This PR adds a `SharedUrl` type to GPUI.
It's just like a `SharedString`, but for denoting that the contained
value is a URL.
Mainlined from @nathansobo's GPUI blog post:
https://github.com/zed-industries/zed/pull/3968/files#diff-7ee75937e2daf7dd53f71b17698d8bd6d46993d06928d411781b9bd739b5f231R9-R12
Release Notes:
- N/A
2024-01-09 10:55:49 -05:00
Antonio Scandurra
84b05d6c05
Maintain view stack as part of DispatchTree
2024-01-09 15:12:23 +01:00
Antonio Scandurra
f55870f378
Reuse mouse and keyboard listeners when reusing geometry for a view
2024-01-09 12:37:24 +01:00
Kirill Bulatov
625c9d8980
Remove some todo!'s
2024-01-09 11:36:36 +02:00
Conrad Irwin
844d161c40
Allow adding write access to guests
2024-01-08 22:02:56 -07:00
Mikayla
27d4d727c3
Attempt to write test
2024-01-08 18:21:54 -08:00
Mikayla
0684369734
Fix off by 1 error when computing available key bindings
2024-01-08 17:30:24 -08:00
Antonio Scandurra
c9193b586b
WIP
2024-01-08 19:31:50 +01:00
Antonio Scandurra
84c36066bc
Start on caching views
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2024-01-08 19:07:20 +01:00
Antonio Scandurra
5904bcf1c2
Use taffy to retrieve the parent for a given layout node
2024-01-08 13:51:38 +01:00
Piotr Osiewicz
53564fb269
Bring back zed.rs tests ( #3907 )
...
At present 3 tests still fail; 2 are related to keymap issues that (I
believe) @maxbrunsfeld is working on. The other one
(`test_open_paths_action`) I'll look into. edit: done
This PR also fixes workspace unregistration, as we've put the code to do
that behind `debug_assert`
(https://github.com/zed-industries/zed/pull/3907/files#diff-041673bbd1947a35d45945636c0055429dfc8b5985faf93f8a8a960c9ad31e28L649 ).
Release Notes:
- N/A
2024-01-08 12:29:54 +01:00
Piotr Osiewicz
d475f1373a
gpui: Further docs refinement & moved some reexports into 'private' module ( #3935 )
...
This commit mostly fixes invalid URLs in docstrings. It also
encapsulates crates we reexport (serde stuff + linkme) into a public
module named "private" in order to reduce the API surfaced through docs.
Moreover, I fixed up a bunch of crates that were pulling serde_json in
through gpui explicitly instead of using Cargo manifest.
Release Notes:
- N/A
2024-01-07 14:14:21 +01:00
Kirill Bulatov
8ff05c6a72
Prepare for external file drop in pane
2024-01-07 01:17:49 +02:00
Piotr Osiewicz
dc7f9bbc54
gpui: Sweep through cargo doc output and mark dubious items as non-public ( #3932 )
...
I essentially went through the publicly exported items and marked these
that are e.g. leaky reexports as pub(crate). I expect that'd be done on
Tuesday anyways.
Release Notes:
- N/A
2024-01-06 23:47:51 +01:00
Nathan Sobo
aaada7d508
Implement From<Rgba> for Fill
2024-01-05 17:33:22 -07:00
Conrad Irwin
709682e8bc
Tidy up TestContext lifecycle
...
Co-Authored-By: Max <max@zed.dev>
2024-01-05 16:31:41 -07:00
Conrad Irwin
204ef451d0
Merge branch 'main' into following-tests
2024-01-05 16:14:12 -07:00
Conrad Irwin
f239a8292e
More following tests
2024-01-05 16:13:40 -07:00
Max Brunsfeld
7e810d7e0d
Restore the ability to disable key bindings by setting them to null
in your keymap ( #3921 )
...
* Fix an incorrect use of `Any::type_id` that prevented the disabling of
key bindings
* Restructured the representation of disabled key bindings so that they
handle context predicates correctly. Previously, to disable key binding,
you needed to supply the exact same context predicate (e.g. `Editor &&
mode == "full"`) as the binding that you are trying to disable. Now, the
context predicates of disabled key bindings are evaluated just like any
other context predicate (with the current context) to see if they apply.
Release Notes:
- Fixed an issue where disabling key bindings didn't work. To disable a
key binding, set it to `null` in your keymap.
2024-01-05 13:51:47 -08:00
Max Brunsfeld
8a96562adf
Handle contexts correctly for disabled key bindings
2024-01-05 13:06:59 -08:00
Piotr Osiewicz
254a52d0a1
gpui: Remove dependency on sqlez ( #3871 )
...
This removes one of the path dependencies in gpui that's only really
needed by `workspace` (which can work around lack of these
implementations by itself). In theory it should also improve build
scheduling (as gpui doesn't have to wait for main dependency of sqlez -
libsqlite3 - to finish it's 25 seconds-long build in release), though in
practice I didn't notice a substantial improvement.
Moreover `sqlez` was unused by `settings` too, so that's removed
as well.
Release Notes:
- N/A
2024-01-05 19:36:55 +01:00
Conrad Irwin
3c0052850c
Merge branch 'main' into channel-guests
2024-01-05 10:05:59 -07:00