Max Brunsfeld
a125610f81
Assign draw order to surfaces using plane splitter ( #3739 )
...
It looks like we neglected to incorporate surfaces into the
plane-splitting code path, which assigns each graphics primitive's draw
order.
This fixes an issue where screensharing frames were not visible when the
screenshare tab was zoomed.
2023-12-20 09:54:03 -08:00
Marshall Bowers
87f879bfa9
Add text wrapping to notifications
2023-12-20 12:48:30 -05:00
Nathan Sobo
dc047437c6
Don't consider any element hovered when actively dragging
...
Co-Authored-By: Antonio <antonio@zed.dev>
2023-12-20 10:46:36 -07:00
Marshall Bowers
9c4e8699ba
Remove unneeded wrapping element
2023-12-20 12:45:18 -05:00
Max Brunsfeld
8f677cc0c6
Assign draw order to surfaces using plane splitter
2023-12-20 09:43:04 -08:00
Julia
e1a4e8ea16
Reintroduce LSP diagnostic/status message ( #3728 )
...
Release Notes:
- N/A
2023-12-20 12:23:36 -05:00
Julia
11140a1d34
Use ButtonLike rather than ad-hoc button
...
Co-Authored-By: Marshall Bowers <marshall@zed.dev>
2023-12-20 12:15:13 -05:00
Antonio Scandurra
90db278724
Prevent ArenaRef
from being cloned ( #3738 )
...
This could cause multiple mutable references to be acquired for the same
arena element, which is unsafe. I didn't see it cause problems in
practice, but I realized this could have been a problem and fixed it
before it bit us.
Release Notes:
- N/A
2023-12-20 17:52:16 +01:00
Marshall Bowers
636c12ec3f
Style signed-out and empty states for the notification panel
2023-12-20 11:45:18 -05:00
Marshall Bowers
3886b1993d
Fix formatting breakage
2023-12-20 11:41:51 -05:00
Antonio Scandurra
6e2346c537
Prevent ArenaRef
from being cloned
2023-12-20 17:32:59 +01:00
Julia
5840750b3d
Avoid workspace use while leased
2023-12-20 11:28:56 -05:00
Kirill Bulatov
fc923a2a98
Close syntax tree view menu on click too
2023-12-20 18:28:32 +02:00
Marshall Bowers
5145795f33
Adjust styles for notification panel container
2023-12-20 11:27:28 -05:00
Kirill Bulatov
331af82cb1
Rework context menu's custom element API to handle clicks properly
2023-12-20 18:23:09 +02:00
Kirill Bulatov
19d1568140
Lsp log selector fixes
2023-12-20 18:23:09 +02:00
Kirill Bulatov
fe40e3920b
Fix remaining z-index bugs
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-12-20 18:23:09 +02:00
Kirill Bulatov
1474816a93
Syntax tree panel style fixes
2023-12-20 18:23:08 +02:00
Kirill Bulatov
7b83d65deb
Remove temporary imports, fix syntax_tree_view
2023-12-20 18:23:08 +02:00
Kirill Bulatov
6a90a76bf2
Use stock gpui2 ui components
2023-12-20 18:23:08 +02:00
Kirill Bulatov
3586bf8b6b
Display something
2023-12-20 18:23:08 +02:00
Kirill Bulatov
c1f8929e43
Add new panels into zed2
2023-12-20 18:23:08 +02:00
Kirill Bulatov
7e6dac383e
Uncomment tests
2023-12-20 18:23:08 +02:00
Kirill Bulatov
8471a5f80b
Finish all but the styling
2023-12-20 18:23:08 +02:00
Kirill Bulatov
75074c3297
Apply more fixes to the visual part
2023-12-20 18:23:08 +02:00
Kirill Bulatov
676a07270e
First fixes
2023-12-20 18:23:08 +02:00
Kirill Bulatov
64925231b0
Create a new crate
2023-12-20 18:23:08 +02:00
Marshall Bowers
229b5aa8f7
Style links in terminal ( #3736 )
...
This PR styles links in the terminal using the colors from the theme.
Release Notes:
- N/A
2023-12-20 10:57:15 -05:00
Nathan Sobo
5b29c89e1c
Clear pending click state when dragging
...
Once a drag starts, we won't fire click listeners or style any elements
as active.
Co-Authored-By: Antonio <antonio@zed.dev>
2023-12-20 08:55:18 -07:00
Nathan Sobo
12bb13b9fc
Perform a bounds check when allocating in the arena
...
This ensures we don't invoke undefined behavior when overflowing.
Co-Authored-By: Antonio <antonio@zed.dev>
2023-12-20 08:20:00 -07:00
Antonio Scandurra
6e1ba645f3
Show button as selected if screen sharing is on
2023-12-20 14:17:15 +01:00
Antonio Scandurra
57f3a882fe
Render disconnected overlay when project becomes readonly
2023-12-20 14:10:59 +01:00
Antonio Scandurra
390ccbc6ad
Disable focus when disconnecting from host
2023-12-20 14:10:56 +01:00
Antonio Scandurra
8273865fa3
Introduce InteractiveElement::capture_any_mouse_{down,up}
2023-12-20 14:00:12 +01:00
Antonio Scandurra
5781cf6604
Use InteractiveBounds
everywhere we change the cursor style
2023-12-20 13:59:52 +01:00
Piotr Osiewicz
2f57a3ccfb
Popover buttons titlebar ( #3732 )
...
Migrate project picker/vcs menu to use popover_menu.
Release Notes:
- N/A
2023-12-20 12:47:53 +01:00
Antonio Scandurra
00927db711
Fix sluggish experience when dragging tabs
...
The problem was caused by a missing call to `WindowContext::notify` when
moving the mouse. Actually, we *did* notify as part of a `MouseMoveEvent`
listener registered in `Interactivity` but that code path was never
exercised because we were clearing the `pending_mouse_down`.
This commit fixes the issue by automatically redrawing the window in gpui
when there is an active drag and the mouse moves.
2023-12-20 11:21:55 +01:00
Max Brunsfeld
c81e89a4f4
Ensure that new view observers are called by WindowContext::replace_root_view
2023-12-19 17:04:42 -08:00
Max Brunsfeld
71d17e268d
Fix layout of diagnostic blocks ( #3729 )
...
Previously, all of the lines in a multi-line error message were painted
on top of each other. I also simplified the logic for highlighting
backtick-enclosed ranges in a diagnostic message.
2023-12-19 15:49:56 -08:00
Max Brunsfeld
3fccc648d6
Fix layout of diagnostic blocks
2023-12-19 15:41:00 -08:00
Julia
0390fb1449
Reintroduce LSP diagnostic/status message
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-12-19 18:38:25 -05:00
Marshall Bowers
afcf6c6852
Map textLink.activeForeground
from VS Code to link_text_hover
2023-12-19 18:29:27 -05:00
Marshall Bowers
a0224b975b
Use link_text_hover
for go-to-definition links
2023-12-19 18:24:52 -05:00
Marshall Bowers
53b76e3e4d
Style pane drop targets ( #3726 )
...
This PR styles the pane drop targets using the `drop_target_background`
color from the theme.
We do have to adjust the alpha channel of the color so that it doesn't
obscure the contents of the buffer.
Release Notes:
- N/A
2023-12-19 18:06:21 -05:00
Marshall Bowers
547ad77243
Style tab drop targets for project entries ( #3725 )
...
This PR styles the drop targets when dragging a project entry onto a tab
or the tab bar.
I also adjusted the existing tab drop targets to use the
`drop_target_background` from the theme.
Release Notes:
- N/A
2023-12-19 17:45:42 -05:00
Max Brunsfeld
599ec5c25b
Make collab panel usable from the keyboard, add missing styling ( #3724 )
...
* allow confirming all items via the keyboard
* allow deploying the channel context menu via the keyboard
* add missing selected styling for list items
2023-12-19 14:33:56 -08:00
Max Brunsfeld
afd3bf7746
Add missing selected state and keyboard action for some collab panel items
2023-12-19 14:16:44 -08:00
Max Brunsfeld
901795bcb9
Don't reset the collab panel when it loses focus
2023-12-19 14:12:29 -08:00
Kirill Bulatov
acbb3f39f6
Better display items from different sources with different z-indices in the same place ( #3723 )
2023-12-20 00:01:37 +02:00
Kirill Bulatov
cf12d62fc5
Tidy up z-index handling
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2023-12-19 23:50:42 +02:00