Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ZIm/crates/eval/examples/request_to_axios_migration/diff_criteria.md
Nathan Sobo bab28560ef
Systematically optimize agentic editing performance (#28961) 
Now that we've established a proper eval in tree, this PR is reboots of
our agent loop back to a set of minimal tools and simpler prompts. We
should aim to get this branch feeling subjectively competitive with
what's on main and then merge it, and build from there.

Let's invest in our eval and use it to drive better performance of the
agent loop. How you can help: Pick an example, and then make the outcome
faster or better. It's fine to even use your own subjective judgment, as
our evaluation criteria likely need tuning as well at this point. Focus
on making the agent work better in your own subjective experience first.
Let's focus on simple/practical improvements to make this thing work
better, then determine how we can craft our judgment criteria to lock
those improvements in.

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Agus <agus@zed.dev>
Co-authored-by: Richard <richard@zed.dev>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Michael Sloan <mgsloan@gmail.com>
2025-04-19 02:47:59 +00:00

1.1 KiB
Raw Blame History

  1. The first change replaces the request module import with axios in Tunnel.js. This is accompanied by modifications to the request parameters where path and json fields are removed and replaced with responseType: 'json'. The request URI construction is also slightly modified to separate the base URI from the parameters.
  2. The second chunk shows significant changes to the request handling logic in Tunnel.js. The callback-based request implementation is replaced with a promise-based axios.get approach. The error handling is restructured to use .catch() instead of checking for errors in the callback. The success case now extracts data from res.data instead of directly from the response body, and the status code check looks at res.status instead of res.statusCode.
  3. The third chunk shows changes to package.json where the request dependency is removed and replaced with axios at version 0.17.1. The dependencies are also reordered, with debug and openurl moved up and yargs moved to the end of the list, though their versions remain unchanged. The devDependencies section remains untouched.