Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ZIm/crates/eval/examples/time_detail_merge_update/diff_criteria.md
Nathan Sobo bab28560ef
Systematically optimize agentic editing performance (#28961) 
Now that we've established a proper eval in tree, this PR is reboots of
our agent loop back to a set of minimal tools and simpler prompts. We
should aim to get this branch feeling subjectively competitive with
what's on main and then merge it, and build from there.

Let's invest in our eval and use it to drive better performance of the
agent loop. How you can help: Pick an example, and then make the outcome
faster or better. It's fine to even use your own subjective judgment, as
our evaluation criteria likely need tuning as well at this point. Focus
on making the agent work better in your own subjective experience first.
Let's focus on simple/practical improvements to make this thing work
better, then determine how we can craft our judgment criteria to lock
those improvements in.

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Agus <agus@zed.dev>
Co-authored-by: Richard <richard@zed.dev>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Michael Sloan <mgsloan@gmail.com>
2025-04-19 02:47:59 +00:00

1.5 KiB
Raw Blame History

  1. Function Modification: The write_time_detail function has been refactored into merge_time_detail to modify the behavior of merging time details instead of overwriting them. The merge_time_detail function now adds new values to the existing ones, preserving the data and allowing for cumulative updates, which ensures more accurate tracking of time metrics.
  2. Usage of New Function: All instances where write_time_detail was called have been updated to use merge_time_detail, including in the src/coprocessor/endpoint.rs, src/server/service/kv.rs, src/storage/txn/tracker.rs, and test files. The modification ensures consistency across the codebase by merging time details rather than replacing them.
  3. Test Coverage: A new test, test_select_time_details, has been added in tests/integrations/coprocessor/test_select.rs to validate the proper functioning of time detail merging. The test checks that the process_wall_time_ns field is not zero, ensuring the correct time metrics are being tracked and merged.
  4. Backward Compatibility: The changes do not affect any external functionality or break compatibility. The merging of time details is backward-compatible, as it preserves existing values and adds new ones, which makes the system more flexible for future extensions.
  5. Code Consistency: The naming convention and function signature have been aligned with existing code practices, making the codebase more consistent and easier to maintain.