Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ZIm/crates/eval/examples/rate_limit_endpoints/diff_criteria.md
Nathan Sobo bab28560ef
Systematically optimize agentic editing performance (#28961) 
Now that we've established a proper eval in tree, this PR is reboots of
our agent loop back to a set of minimal tools and simpler prompts. We
should aim to get this branch feeling subjectively competitive with
what's on main and then merge it, and build from there.

Let's invest in our eval and use it to drive better performance of the
agent loop. How you can help: Pick an example, and then make the outcome
faster or better. It's fine to even use your own subjective judgment, as
our evaluation criteria likely need tuning as well at this point. Focus
on making the agent work better in your own subjective experience first.
Let's focus on simple/practical improvements to make this thing work
better, then determine how we can craft our judgment criteria to lock
those improvements in.

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Agus <agus@zed.dev>
Co-authored-by: Richard <richard@zed.dev>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Michael Sloan <mgsloan@gmail.com>
2025-04-19 02:47:59 +00:00

1.3 KiB
Raw Blame History

  1. The main.go changes introduce rate-limited endpoints by creating them via MakeEndpoints and passing them to both HTTP and gRPC servers instead of directly using the service. This includes:
    • Adding endpoint creation before server startup
    • Modifying HTTP server to use endpoints
    • Modifying gRPC server to use endpoints
  2. The server_grpc.go changes update the gRPC server implementation to use the provided endpoints instead of creating them internally. This affects both hash and validate endpoints which are now taken from the Endpoints struct rather than being created via makeHashEndpoint/makeValidateEndpoint.
  3. The server_http.go changes mirror the gRPC server changes, modifying the HTTP server to use endpoints from the Endpoints struct rather than creating them internally for both hash and validate routes.
  4. The service.go changes include:
    • Renaming makeHashEndpoint to MakeHashEndpoint and making it public
    • Renaming makeValidateEndpoint to MakeValidateEndpoint and making it public
    • Adding new MakeEndpoints function that creates rate-limited endpoints using a token bucket (5 requests per second)
    • Adding new dependencies for rate limiting (kitrl and ratelimit packages)
    • The Endpoints struct remains the same but is now populated with rate-limited versions of the endpoints