Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ZIm/crates
History
Kirill Bulatov f895d66d1c
Make language server id more explicit in unhandled message logs (#8131) 
Before:
```
[2024-02-21T18:55:55+02:00 INFO  language::language_registry] starting language server "eslint", path: "/Users/someonetoignore/Downloads/eslint-configs-demo", id: 2
[2024-02-21T18:55:56+02:00 INFO  lsp] 2 unhandled notification window/logMessage:
{
  "type": 3,
  "message": "ESLint server running in node v18.15.0"
}
[2024-02-21T18:55:56+02:00 INFO  lsp] 2 unhandled notification eslint/confirmESLintExecution:
{
  "scope": "local",
  "uri": "file:///Users/someonetoignore/Downloads/eslint-configs-demo/index.js",
  "libraryPath": "/Users/someonetoignore/Downloads/eslint-configs-demo/node_modules/eslint/lib/api.js"
}
```

After:
```
[2024-02-21T18:57:31+02:00 INFO  language::language_registry] starting language server "eslint", path: "/Users/someonetoignore/Downloads/eslint-configs-demo", id: 2
[2024-02-21T18:57:32+02:00 INFO  lsp] Language server with id 2 sent unhandled notification window/logMessage:
{
  "type": 3,
  "message": "ESLint server running in node v18.15.0"
}
[2024-02-21T18:57:32+02:00 INFO  project::prettier_support] Fetching default prettier and plugins: [("prettier-plugin-tailwindcss", "0.5.11"), ("prettier", "3.2.5")]
[2024-02-21T18:57:32+02:00 INFO  lsp] Language server with id 2 sent unhandled notification eslint/confirmESLintExecution:
{
  "scope": "local",
  "uri": "file:///Users/someonetoignore/Downloads/eslint-configs-demo/index.js",
  "libraryPath": "/Users/someonetoignore/Downloads/eslint-configs-demo/node_modules/eslint/lib/api.js"
}
```

We have to pass a name there too, but the problem here is that the
unhandled message callback is created very early, along with the binary,
but the server name is received from the LSP initialize response, which
is a totally separate piece of code.
I plan to refactor that code next, but so far, improve the logs at least
slightly.

Release Notes:

- N/A
2024-02-21 19:11:23 +02:00
..
activity_indicator chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
ai Allow OpenAI API URL to be configured via assistant.openai_api_url (#7552) 2024-02-12 11:37:27 -05:00
assets chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
assistant Hide Inline Assist button if assistant.button is disabled (#7932) 2024-02-18 08:14:08 +02:00
audio chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
auto_update chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
breadcrumbs chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
call revert single channel click (#7738) 2024-02-13 12:53:49 -07:00
channel Add an indicator to the channel chat to see all the messages that you missed (#7781) 2024-02-19 19:20:02 -07:00
cli Actually fail on clippy failures (#7619) 2024-02-09 10:13:00 -08:00
client Use collections::{HashMap, HashSet} instead of its std:: counterpart (#7502) 2024-02-07 19:06:03 +02:00
clock Add documentation to many core editor types (#7919) 2024-02-17 09:03:05 -07:00
collab First pass at making a linux keymap (#8082) 2024-02-20 13:51:54 -08:00
collab_ui chat: auto detect links (#8028) 2024-02-19 21:49:47 -07:00
collections gpui: Add Global marker trait (#7095) 2024-01-30 14:08:20 -05:00
color chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
command_palette Vim: enable sending multiple keystrokes from custom keybinding (#7965) 2024-02-20 15:01:45 -07:00
copilot Copilot: handle "ok" status message when no user is set (#8116) 2024-02-21 11:39:43 +01:00
copilot_ui Add cancel button on GitHub Copilot actions (#7850) 2024-02-16 10:45:55 -05:00
db chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
diagnostics chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
editor Vim: enable sending multiple keystrokes from custom keybinding (#7965) 2024-02-20 15:01:45 -07:00
extension Fix a bug when extension loading is failed after it's folder is viewed by MacOS finder (#8111) 2024-02-21 08:46:58 -08:00
extensions_ui Add button link to extension repository (#7880) 2024-02-16 11:49:05 -05:00
feature_flags chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
feedback vim: Fix renaming (#7714) 2024-02-12 22:28:26 -07:00
file_finder recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
fs Add initial CI job for Windows target (#8088) 2024-02-21 00:35:29 +02:00
fsevent Translate notify::Event to fsevent::Event on linux (#7545) 2024-02-08 08:35:37 -08:00
fuzzy chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
git chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
go_to_line chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
gpui Fix crash when closing last zed window (#8102) 2024-02-21 00:48:42 -05:00
gpui_macros Sort dependencies in Cargo.toml files (#7126) 2024-01-30 21:41:29 -05:00
install_cli Add initial CI job for Windows target (#8088) 2024-02-21 00:35:29 +02:00
journal chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
language Add "code_actions_on_format" (#7860) 2024-02-15 14:19:57 -07:00
language_selector recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
language_tools Add logic for managing language and theme extensions (#7467) 2024-02-07 15:14:50 -05:00
live_kit_client X11: Continuous Presentation (#7762) 2024-02-14 12:24:12 -08:00
live_kit_server Sort dependencies in Cargo.toml files (#7126) 2024-01-30 21:41:29 -05:00
lsp Make language server id more explicit in unhandled message logs (#8131) 2024-02-21 19:11:23 +02:00
markdown_preview Fix display of links in lists (markdown_preview) (#8073) 2024-02-20 11:30:40 -07:00
media Enable Blade on MacOS via "macos-blade" feature (#7669) 2024-02-16 13:39:40 -08:00
menu chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
multi_buffer Add documentation to many core editor types (#7919) 2024-02-17 09:03:05 -07:00
node_runtime Download right language server binary for OS (#8040) 2024-02-20 09:53:03 +02:00
notifications chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
outline recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
picker Vim: enable sending multiple keystrokes from custom keybinding (#7965) 2024-02-20 15:01:45 -07:00
plugin chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
plugin_macros Sort dependencies in Cargo.toml files (#7126) 2024-01-30 21:41:29 -05:00
plugin_runtime Sort dependencies in Cargo.toml files (#7126) 2024-01-30 21:41:29 -05:00
prettier Add Prettier support for Vue, Markdown and PHP (#7904) 2024-02-17 11:35:31 +02:00
project Rename runnables into tasks (#8119) 2024-02-21 14:56:43 +02:00
project_panel Use collections::{HashMap, HashSet} instead of its std:: counterpart (#7502) 2024-02-07 19:06:03 +02:00
project_symbols recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
quick_action_bar Hide Inline Assist button if assistant.button is disabled (#7932) 2024-02-18 08:14:08 +02:00
recent_projects recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
refineable Sort dependencies in Cargo.toml files (#7126) 2024-01-30 21:41:29 -05:00
release_channel chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
rich_text chat: auto detect links (#8028) 2024-02-19 21:49:47 -07:00
rope Add documentation to many core editor types (#7919) 2024-02-17 09:03:05 -07:00
rpc Follower simplification (#8026) 2024-02-20 09:41:37 -07:00
search Project search bar layout improvements (#7963) 2024-02-20 21:07:01 +02:00
semantic_index Allow OpenAI API URL to be configured via assistant.openai_api_url (#7552) 2024-02-12 11:37:27 -05:00
settings Rename runnables into tasks (#8119) 2024-02-21 14:56:43 +02:00
snippet Clean up Cargo.toml files (#7044) 2024-01-29 23:47:20 -05:00
sqlez Use collections::{HashMap, HashSet} instead of its std:: counterpart (#7502) 2024-02-07 19:06:03 +02:00
sqlez_macros chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
story chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00
storybook recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
sum_tree Add documentation to many core editor types (#7919) 2024-02-17 09:03:05 -07:00
task Add task docs and default keybindings (#8123) 2024-02-21 16:43:56 +02:00
tasks_ui Add task docs and default keybindings (#8123) 2024-02-21 16:43:56 +02:00
terminal Rename runnables into tasks (#8119) 2024-02-21 14:56:43 +02:00
terminal_view Runnables: remove version field from the format (#8118) 2024-02-21 14:30:16 +01:00
text Add documentation to many core editor types (#7919) 2024-02-17 09:03:05 -07:00
theme Rename scrollbar_thumb to be consistent with other style properties (#8004) 2024-02-20 11:26:09 -05:00
theme_importer theme_importer: Add --output flag for outputting the theme to a file (#7486) 2024-02-07 16:23:36 -05:00
theme_selector recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
ui Add static Runnables (#8009) 2024-02-19 18:41:43 +02:00
util Rename runnables into tasks (#8119) 2024-02-21 14:56:43 +02:00
vcs_menu recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
vim Vim: enable sending multiple keystrokes from custom keybinding (#7965) 2024-02-20 15:01:45 -07:00
welcome recent projects: cleanup ui (#7528) 2024-02-19 14:37:52 +02:00
workspace Rename runnables into tasks (#8119) 2024-02-21 14:56:43 +02:00
zed Add task docs and default keybindings (#8123) 2024-02-21 16:43:56 +02:00
zed_actions chore: Move workspace dependencies to workspace.dependencies (#7454) 2024-02-06 20:41:36 +01:00